alamb commented on code in PR #16509: URL: https://github.com/apache/datafusion/pull/16509#discussion_r2161855265
########## datafusion/physical-plan/src/sorts/cursor.rs: ########## @@ -293,14 +293,19 @@ impl CursorValues for StringViewArray { self.views().len() } + #[inline(always)] Review Comment: For anyone else following along, I believe this is the same optimization as applied in - https://github.com/apache/arrow-rs/pull/7731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org