xudong963 commented on issue #16188: URL: https://github.com/apache/datafusion/issues/16188#issuecomment-2994977304
@adriangb @alamb Thank you, now I understand the background about the filter pushdown in logical & physical phases. > The main con of having TableProvider attach the filters to the scan is that implementing it correctly is quite cumbersome and makes custom TableProvider's more complex, with TableProvider being one of the most common hooks in DataFusion. Having that happen as an optimizer rule keeps the complexity out of the TableProvider. I see, we should keep custom TableProviders easy to implement and reduce the users' burden. It's fair to keep the current status. Thanks for your detailed explanation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
