geoffreyclaude commented on code in PR #16469:
URL: https://github.com/apache/datafusion/pull/16469#discussion_r2160019640
##########
datafusion/physical-plan/src/execution_plan.rs:
##########
@@ -580,6 +581,24 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
// cooperate with yielding.
None
}
+
+ /// Returns a new execution plan that uses the provided work table, if
supported.
Review Comment:
Hi @alamb,
I'm glad you mention the `Any` solution! I was initially going with
something similar, but it seemed to me only the `WorkTableExec` needed this, so
I didn't want to over-generalize.
However, moving to the `Any` solution anytime in the future (maybe because
this late update pattern becomes more frequent for other concrete nodes) will
mean breaking the specific `WorkTableExec` implementation.
So for the sake of forward compatibility, I very much agree with your
suggested signature! I'll update the PR and mention you once done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
