2010YOUY01 opened a new issue, #16493: URL: https://github.com/apache/datafusion/issues/16493
### Is your feature request related to a problem or challenge? `BaselineMetrics` provides a common set of metrics that should be included by all operators. This way we can keep those basic metrics consistent and also simplify implementation when adding more metrics into `BaselineMetrics` https://github.com/apache/datafusion/blob/a4f4b17f0461b94f220b024ba502c8664f590b9b/datafusion/physical-plan/src/metrics/baseline.rs#L47-L56 However, @hendrikmakait noticed in https://github.com/apache/datafusion/issues/16244#issuecomment-2991828951 that, some operators are not using `BaselineMetrics`, and instead include the same basic metrics into their specific metrics struct. Specifically, SMJ operator keeps the same `output_rows` metrics but it's missing other baseline metircs. https://github.com/apache/datafusion/blob/a4f4b17f0461b94f220b024ba502c8664f590b9b/datafusion/physical-plan/src/joins/sort_merge_join.rs#L603-L619 I think it's a good idea to clean it up by reusing `BaselineMetrics`. ### Describe the solution you'd like Refactor `SortMergeJoinMetrics` to reuse `BaselineMetrics` ### Describe alternatives you've considered _No response_ ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
