adriangb commented on PR #16080: URL: https://github.com/apache/datafusion/pull/16080#issuecomment-2992639239
Thanks for linking Andrew. So it seems to me that previously: - Statistics were collected by `ListingTable` despite the config being set to not collect them - This PR made `ListingTable` obey the config, but in doing so changed the default for some use patterns of `ListingTable` from `true` to `false` - #16158 made the config default `true` - thus reverting the change for the users in the point above but introduce a change for other users, e.g. I think default usage of `datafusion-cli` will now collect stats wheres it did not before My read of this is that collecting stats can be beneficial or hurt depending on details of the query, etc. and before this PR there were 2 different defaults going around and after there is just one. So we just need to decide what the default is. We've decided it's going to be `true`. There's a possibility that other users complain about the behavior change by setting the default to `true` in which case we either have to stick to our guns with a choice (my vote) or revert this PR and go back to having 2 different defaults. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
