ctsk commented on PR #16463: URL: https://github.com/apache/datafusion/pull/16463#issuecomment-2989084548
At SF=100, this PR is 10% faster: ``` -------------------- Benchmark tpch_sf100.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ pr ┃ old ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 1728.00 ms │ 1755.28 ms │ no change │ │ QQuery 2 │ 1356.73 ms │ 1241.24 ms │ +1.09x faster │ │ QQuery 3 │ 1987.91 ms │ 1995.85 ms │ no change │ │ QQuery 4 │ 1509.51 ms │ 1593.78 ms │ 1.06x slower │ │ QQuery 5 │ 3676.40 ms │ 3770.53 ms │ no change │ │ QQuery 6 │ 277.50 ms │ 287.08 ms │ no change │ │ QQuery 7 │ 3542.47 ms │ 3499.00 ms │ no change │ │ QQuery 8 │ 4037.40 ms │ 4228.35 ms │ no change │ │ QQuery 9 │ 5968.77 ms │ 5910.46 ms │ no change │ │ QQuery 10 │ 1716.65 ms │ 1666.84 ms │ no change │ │ QQuery 11 │ 1059.97 ms │ 1005.02 ms │ +1.05x faster │ │ QQuery 12 │ 1091.32 ms │ 1110.42 ms │ no change │ │ QQuery 13 │ 1121.01 ms │ 1234.91 ms │ 1.10x slower │ │ QQuery 14 │ 587.82 ms │ 535.24 ms │ +1.10x faster │ │ QQuery 15 │ 904.97 ms │ 890.88 ms │ no change │ │ QQuery 16 │ 731.39 ms │ 745.86 ms │ no change │ │ QQuery 17 │ 5760.02 ms │ 5919.10 ms │ no change │ │ QQuery 18 │ 6404.64 ms │ 8073.58 ms │ 1.26x slower │ │ QQuery 19 │ 688.99 ms │ 666.94 ms │ no change │ │ QQuery 20 │ 1725.25 ms │ 1742.06 ms │ no change │ │ QQuery 21 │ 7427.94 ms │ 10795.91 ms │ 1.45x slower │ │ QQuery 22 │ 1373.74 ms │ 1370.31 ms │ no change │ └──────────────┴────────────┴─────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (fx) │ 54678.41ms │ │ Total Time (HEAD) │ 60038.64ms │ │ Average Time (fx) │ 2485.38ms │ │ Average Time (HEAD) │ 2729.03ms │ │ Queries Faster │ 3 │ │ Queries Slower │ 4 │ │ Queries with No Change │ 15 │ │ Queries with Failure │ 0 │ └────────────────────────┴────────────┘ ``` Perhaps a threshold is needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
