pepijnve opened a new pull request, #16455: URL: https://github.com/apache/datafusion/pull/16455
Using 1 as the basis index makes it easier to correlate benchmark runs with query files in an editor ## Which issue does this PR close? None ## Rationale for this change Clickbench query IDs are currently zero-based, while most (if not all) text editors are 1-based when it comes to line numbering. Using 1-based ids makes it easier to correlate benchmark output with the query files. Additionally TPCH IDs are already 1-based, so this aligns the two. ## What changes are included in this PR? Change clickbench runner to start counting at 1. ## Are these changes tested? Manual testing ## Are there any user-facing changes? Clickbench query IDs in benchmark output are all incremented by one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
