parthchandra commented on code in PR #1910:
URL: https://github.com/apache/datafusion-comet/pull/1910#discussion_r2155783253
##########
dev/diffs/3.5.6.diff:
##########
@@ -1938,7 +1938,17 @@ index 8e88049f51e..d3c0737d52e 100644
import testImplicits._
// keep() should take effect on StartsWith/EndsWith/Contains
Seq(
-@@ -1984,7 +1997,8 @@ abstract class ParquetFilterSuite extends QueryTest with
ParquetTest with Shared
+@@ -1743,7 +1756,8 @@ abstract class ParquetFilterSuite extends QueryTest with
ParquetTest with Shared
+ }
+ }
+
+- test("SPARK-17091: Convert IN predicate to Parquet filter push-down") {
++ test("SPARK-17091: Convert IN predicate to Parquet filter push-down",
++ IgnoreCometNativeScan("Comet has different push-down behavior")) {
Review Comment:
I believe we don't need to revisit predicate push-down in general. This
specific case is only for the predicate involving an IN clause
So in `select a from foo where b = 2` the predicate will be pushed down
but in `select a from foo where b in (2)` the predicate is not being pushed
down it appears
We have not investigate this failure too deeply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
