epgif commented on PR #16401: URL: https://github.com/apache/datafusion/pull/16401#issuecomment-2982140980
> @alamb > > > I wonder if there is some way we can write a test for it (mostly to prevent it from being accidentally broken/changed in the future) > > I looked around for some tests implementing this interface that I could extend, but didn't find any. I tried panic-driven development and identified various unrelated test, none providing a clue. The trick here is a test needs to check that one function is called rather than another. This seems like a classic low-level unit test. So, that's what I've done. It looks noisy if you're not used to this kind of test, but it does work, and does provide the expected failure when the `information_schema.rs` part is reverted (i.e. wrong function called). Let me know what you think. Thanks, @alamb! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
