mbutrovich commented on code in PR #1892: URL: https://github.com/apache/datafusion-comet/pull/1892#discussion_r2152594347
########## spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala: ########## @@ -232,6 +232,21 @@ class CometArrayExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelp } } + test("array_max") { + withSQLConf(CometConf.COMET_EXPR_ALLOW_INCOMPATIBLE.key -> "true") { Review Comment: Can we document why we need this? Is there a specific scenario where Comet's array_max behavior differs from Spark? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org