adriangb commented on PR #16424: URL: https://github.com/apache/datafusion/pull/16424#issuecomment-2980039846
> > Do we expect the benchmarks to show anything? I don't think they're using dynamic filters right? Maybe we need to merge #15770 and then we can benchmark this? > > I want to make sure the overhead of checking the predicates on each incoming batch didn't slow things down If you check the code that only happens _if_ there are dynamic filters. And since there are non right now it becomes just a `if let Some(file_pruner) = file_pruner.as_ref()` check which is going to be too cheap to show up in benchmarks. The only way to actually verify will be to merge https://github.com/apache/datafusion/pull/15770 and then compare this PR to main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
