alamb commented on code in PR #16418:
URL: https://github.com/apache/datafusion/pull/16418#discussion_r2149552742
##########
datafusion/core/Cargo.toml:
##########
@@ -79,6 +81,9 @@ recursive_protection = [
"datafusion-physical-optimizer/recursive_protection",
"datafusion-sql/recursive_protection",
]
+# Enable sqlparser's default features for backward compatibility
+sqlparser_std = ["sqlparser/std"]
+sqlparser_recursive_protection = ["sqlparser/recursive-protection"]
Review Comment:
Is there any need to add this new `sqlparser_recursive_protection =
["sqlparser/recursive-protection"]` feature? could we instead just add it to
the recursive_protection existing feature?
```toml
recursive_protection = [
"datafusion-common/recursive_protection",
"datafusion-expr/recursive_protection",
"datafusion-optimizer/recursive_protection",
"datafusion-physical-optimizer/recursive_protection",
"datafusion-sql/recursive_protection",
"sqlparser/recursive-protection", # Add this???
]
```
I also don't fully understand why we need a new feature for sqlparser_std as
that would seem to already be enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
