Chen-Yuan-Lai commented on code in PR #16324:
URL: https://github.com/apache/datafusion/pull/16324#discussion_r2148615171
##########
datafusion/core/tests/sql/explain_analyze.rs:
##########
@@ -797,14 +796,16 @@ async fn explain_physical_plan_only() {
let sql = "EXPLAIN select count(*) from (values ('a', 1, 100), ('a', 2,
150)) as t (c1,c2,c3)";
let actual = execute(&ctx, sql).await;
let actual = normalize_vec_for_explain(actual);
Review Comment:
After searching `ExplainNormalizer` in the codebase, I found that only four
test cases used it:
1. `test_physical_plan_display_indent` (initialize `ExplainNormalizer`)
2. `test_physical_plan_display_indent_multi_children` (initialize
`ExplainNormalizer`)
3. `explain_logical_plan_only` (call `normalize_vec_for_explain`)
4. `explain_physical_plan_only` (call `normalize_vec_for_explain`)
1.2. created the physical plan with fixed core numbers (90000), and 3. 4.
doesn't have `partitioning=RoundRobinBatch()` string in the snapshot, so I
think this change may not be necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
