jonathanc-n commented on PR #16390: URL: https://github.com/apache/datafusion/pull/16390#issuecomment-2973341692
@Dandandan Yes, it was mentioned in the original pull request. I concluded that if it is better for the nested loop join to take a equijoin condition (where one table's rows are under a certain threshold) and the `null_equals_null = true`, then we will pass in the join condition under the join filter using the `<=>`; if `null_equals_null` = false, then we will just pass it in as `=`. I'll just move the todo statement to the physical planner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
