jonathanc-n commented on code in PR #16388:
URL: https://github.com/apache/datafusion/pull/16388#discussion_r2144347173


##########
datafusion/core/src/execution/session_state.rs:
##########
@@ -1675,6 +1675,13 @@ impl ContextProvider for SessionContextProvider<'_> {
             .get(name)
             .cloned()
             .ok_or_else(|| plan_datafusion_err!("table function '{name}' not 
found"))?;
+        let dummy_schema = DFSchema::empty();

Review Comment:
   I think the original issue mentions being able to reference existing columns.
   
   For example:
   ```sql SELECT * FROM t, range(t.id, t.id + 5); ```
   
   I think the solution to this instead would be to have the a `ExprSimplifier` 
optimizer rule where it can reference the column values. @Lordworms WDYT?
   
   



##########
datafusion/core/src/execution/session_state.rs:
##########
@@ -1675,6 +1675,13 @@ impl ContextProvider for SessionContextProvider<'_> {
             .get(name)
             .cloned()
             .ok_or_else(|| plan_datafusion_err!("table function '{name}' not 
found"))?;
+        let dummy_schema = DFSchema::empty();

Review Comment:
   I think the original issue mentions being able to reference existing columns.
   
   For example:
   ``` SELECT * FROM t, range(t.id, t.id + 5); ```
   
   I think the solution to this instead would be to have the a `ExprSimplifier` 
optimizer rule where it can reference the column values. @Lordworms WDYT?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to