ozankabak commented on PR #16196: URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2956234465
@zhuqi-lucas, talking about TODO items, in addition to the 4 things I noted in [my comment above](https://github.com/apache/datafusion/pull/16196#issuecomment-2955853539), I suggest the following: As we study interleave-related cases in more detail, I think we should add a test case with an interleave in a plan that doesn't have `RepartitionExec`. This can happen when data comes in already partitioned. I think in such cases we can still trigger non-cancellability with `InterleaveExec`'s current code/logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
