kosiew commented on code in PR #16305:
URL: https://github.com/apache/datafusion/pull/16305#discussion_r2135753696
##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -768,6 +808,9 @@ impl ListingTable {
///
/// See documentation and example on [`ListingTable`] and
[`ListingTableConfig`]
pub fn try_new(config: ListingTableConfig) -> Result<Self> {
+ // Extract schema_source before moving other parts of the config
+ let schema_source = config.schema_source().clone();
Review Comment:
> make sense to #derive(Copy) so we didn't have to clone it explicitly.
💯 and [implemented
here](https://github.com/apache/datafusion/pull/16305/commits/21ad8fbc3a7728fa04c943c9bedd01acd9766b01).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
