Blizzara opened a new pull request, #16345: URL: https://github.com/apache/datafusion/pull/16345
## Which issue does this PR close? - Closes #. ## Rationale for this change This adds support for all list types (LargeList, ListView etc) in the schema renaming, as well as dict/ree/union types. Dunno how necessary those are, but seems right to support them still. And this refactors the method to be a bit more usable. The rename_field is IMO a bit confusing with it's "rename_self" parameter. Also there are times when one wants to just rename a data type, so now that's supported too. And I'd like to reuse the same code within our codebase, since with Substrait the case of renaming a field/type comes up a bunch, so I'd like to make these functions "pub". ## What changes are included in this PR? - refactor `rename_field` into `rename_field`, `rename_fields_data_type` and `rename_data_type` - make all three `pub` so that they can be used by downstream projects implementing Substrait things, since the renaming comes up quite often with Substrait and these are convenient for handling it - make rename_data_type's match exhaustive and implement the rest of the types <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? Existing tests, + some additional cases for the newly supported types. <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? `rename_field`, `rename_fields_data_type` and `rename_data_type` are now `pub` in substrait consumer <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
