tlm365 commented on code in PR #16335:
URL: https://github.com/apache/datafusion/pull/16335#discussion_r2135442763
##########
datafusion/functions/src/string/to_hex.rs:
##########
@@ -117,10 +132,8 @@ impl ScalarUDFImpl for ToHexFunc {
}
fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> {
- use DataType::*;
-
Ok(match arg_types[0] {
- Int8 | Int16 | Int32 | Int64 => Utf8,
Review Comment:
@xudong963 Thanks for reviewing,
> Why removed `Int8` and `Int16`?
Ah, that was my mistake, actually should have included more instead! I've
updated it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
