pepijnve commented on PR #16322: URL: https://github.com/apache/datafusion/pull/16322#issuecomment-2953693505
@berkaysynnada I hope it's ok that I ping you directly; reaching out because I believe you are the other of the test case in question. I believe this PR surfaced a mistake in the `CongestedStream` implementation of the test case. That `Stream` was returning `Pending` without ensuring the waker was set up to be notified when the congestion condition cleared. I'm fairly confident that's not correct since the [trait contract](https://docs.rs/futures/latest/futures/prelude/trait.Stream.html#tymethod.poll_next) explicitly states > `Poll::Pending` means that this stream’s next value is not ready yet. Implementations will ensure that the current task will be notified when the next value may be ready. I've fixed the test implementation which makes the test pass again, but would like to get your opinion on this. Maybe I'm missing something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
