alamb opened a new pull request, #16317: URL: https://github.com/apache/datafusion/pull/16317
## Which issue does this PR close? - Related to https://github.com/apache/datafusion/issues/15797 - Follow on to https://github.com/apache/datafusion/pull/16170 - This is an updated version of https://github.com/timsaucer/datafusion/pull/2 ## Rationale for this change As discussed on https://github.com/apache/datafusion/pull/16170#issuecomment-2951165941, we made an initial PR to add metadata to Expr::Literal as part of DataFusion 48, but the API could use a bit of fine tuning to: 1. Encapsulate the details more (so we don't have to migrated between different Map types, for example) 2. Make cloning faster ## What changes are included in this PR? 1. Encapsulate the representation of metadata into a struct `FieldMetadata` 1. Wrap the inner with an `Arc` to make it fast to clone ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 3. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
