alamb commented on code in PR #16300:
URL: https://github.com/apache/datafusion/pull/16300#discussion_r2132143370
##########
datafusion-cli/src/object_storage.rs:
##########
@@ -256,6 +305,9 @@ impl ExtensionOptions for AwsOptions {
"allow_http" => {
self.allow_http.set(rem, value)?;
}
+ "skip_signature" | "nosign" => {
Review Comment:
here is support for passing through `skip_signature`
##########
datafusion-cli/src/object_storage.rs:
##########
@@ -493,29 +576,27 @@ mod tests {
);
let ctx = SessionContext::new();
Review Comment:
Looking at this with whitespace blind diff
https://github.com/apache/datafusion/pull/16300/files?w=1
makes it easier to see what is happening
Specifically, I just refactored the parsing / table_options extraction into
a separate function to reduce repetition.
Otherwise the existing tests are the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
