andygrove commented on code in PR #16256:
URL: https://github.com/apache/datafusion/pull/16256#discussion_r2128850266
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/primitive.rs:
##########
@@ -121,7 +122,7 @@ impl<T: ArrowPrimitiveType, const NULLABLE: bool>
GroupColumn
// Otherwise, we need to check their values
}
- *equal_to_result = self.group_values[lhs_row] ==
array.value(rhs_row);
+ *equal_to_result =
self.group_values[lhs_row].is_eq(array.value(rhs_row));
Review Comment:
The implementation of `is_eq` for floating point is `self.to_bits() ==
rhs.to_bits()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
