chenkovsky commented on issue #16252: URL: https://github.com/apache/datafusion/issues/16252#issuecomment-2944193292
https://github.com/apache/arrow-rs/blame/6deefb7d6163dceb360236078d5d9f10d1021422/arrow-select/src/take.rs#L480 When the length overflows, it will panic, which may not be a good idea. Because overflow does not necessarily mean there is a problem with the program. In the current case, it is just because the indices array is too large. One possible solution is to automatically convert to LargeUtf8 when we find overflow, but this may break some schema consistency checks. Another solution is to allow returning Vec<ArrayRef>. But these will have some API changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
