2010YOUY01 commented on PR #16255: URL: https://github.com/apache/datafusion/pull/16255#issuecomment-2943542788
> LGTM Thank you @2010YOUY01 , i have minor question: > > Do we test before, does those BaselineMetrics will affect performance when large data set? Thanks for the review. To the question: currently no IMO -- because the overhead is just adding a number to an atomic var once per batch. But it might cause slowdown if we want to implement https://github.com/apache/datafusion/issues/16244#issuecomment-2938068143, more benchmarks will be needed for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
