comphead commented on code in PR #1835:
URL: https://github.com/apache/datafusion-comet/pull/1835#discussion_r2124107669
##########
native/spark-expr/src/array_funcs/get_array_struct_fields.rs:
##########
@@ -150,11 +150,23 @@ fn get_array_struct_fields<O: OffsetSizeTrait>(
.downcast_ref::<StructArray>()
.expect("A struct is expected");
- let column = Arc::clone(values.column(ordinal));
let field = Arc::clone(&values.fields()[ordinal]);
- let offsets = list_array.offsets();
- let array = GenericListArray::new(field, offsets.clone(), column,
list_array.nulls().cloned());
+ // Get struct column by ordinal and attach null buffer from original values
+ // In some cases, nulls in parent struct is not reflected in struct column.
Review Comment:
this is an actual fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
