Chen-Yuan-Lai commented on issue #15791:
URL: https://github.com/apache/datafusion/issues/15791#issuecomment-2933783071
@blaginin Thank you for following up on this. I noticed some tests used a
customized assertion macro, so I have two questions for this:
1. For `assert_metrics`: I'm unable to use inline `assert_snapshot!` within
the macro, so I modified it to return the matching lines from the plan and use
`assert_snapshot!()` (with filters to redact strings) in the test. I'm unsure
about the snapshot strategy: should I call `assert_snapshot!()` once for each
line individually, or combine all the target lines into a single snapshot call?
2. For `assert_optimized` in `physical_optimizer/enforce_sorting.rs`, the
macro has logic for checking not only the plan text, but also the tree node
integrity. In this case, should I:
a. Only move the plan text checking from the macro and replace it with
`assert_snapshot!()`, or
b. Move and replace all the checks in the macro? This would require
changing the `check_integrity()` function in `physical_optimizer/test_utils.rs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
