blaginin commented on issue #15395: URL: https://github.com/apache/datafusion/issues/15395#issuecomment-2931763906
I feel like with https://github.com/apache/datafusion/issues/15178 almost done, this ticket can finally be wrapped up ☺️ > The challenge is that it will change the schema of the output That's true. For example above, the column name would change from `Int64(3)` to `3`. It's definitely a breaking change, so maybe we should roll it into the next major release? I've been thinking about what could break for users, and came up with: - Expected column name. But the case with raw ints feels pretty minor, especially if you exclude people who don’t give the column a meaningful name (which I think is the intended behaviour). - Column duplicates, e.g. we had `Int64(1)` and `Int32(1)` but they’d both now become just `1`. This feels like a very weird edge case. And moreover hard to achieve: if you used `arrow_cast` to set the type, it'll still be in the column name. - Harder to understand the column type - but I think https://github.com/apache/datafusion/issues/15442 already addresses that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
