nucccc commented on issue #1861:
URL:
https://github.com/apache/datafusion-sqlparser-rs/issues/1861#issuecomment-2927948906
I'm trying to take a look into that, and I'm trying to evaluate if a new
type shall be declared inside `src/ast/data_type.rs` or an existing one shall
be reused.
For example there is
```rust
/// Datetime with optional time precision, see [MySQL][1].
///
/// [1]: https://dev.mysql.com/doc/refman/8.0/en/datetime.html
Datetime(Option<u64>),
```
but it has a different name, and snowflake seems to have several timestamp
types all with precision. I don't know if it is appropriate to "augment"
`TimestampNtz` with a precision
```rust
/// Databricks timestamp without time zone. See [1].
///
/// [1]:
https://docs.databricks.com/aws/en/sql/language-manual/data-types/timestamp-ntz-type
TimestampNtz,
```
since afterall it already refers to Databricks.
I think that once a proper datatype is defined it could be possible to
modify `parse_data_type_helper` from `src/parser/mod.rs` to account for that
type.
In any case I saw that support for `TIMESTAMP_NTZ` was added in
https://github.com/apache/datafusion-sqlparser-rs/commit/91327bb0c02a09e0b5c5322c813c4b2a3b564439,
but I don't know how the code would behave before, also because that commit
seems to have introduced the `TIMESTAMP_NTZ` keyword, that before was not
existing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
