comphead commented on code in PR #1788:
URL: https://github.com/apache/datafusion-comet/pull/1788#discussion_r2110176644
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -862,7 +862,8 @@ abstract class CometTestBase
testName: String = "test",
tableName: String = "tbl",
sqlConf: Seq[(String, String)] = Seq.empty,
- debugCometDF: DataFrame => Unit = _ => ()): Unit = {
+ debugCometDF: DataFrame => Unit = _ => (),
+ checkCometOperator: Boolean = true): Unit = {
Review Comment:
does not related directly, but this extends testing method functionality
little bit to support tests which doesn't require all native comet operators.
Used this extension to find that map_keys projection is not supported
##########
native/core/src/execution/planner.rs:
##########
@@ -3232,4 +3232,113 @@ mod tests {
Ok(())
}
+
+ /*
+ Testing a nested types scenario map[struct, struct]
+
+ select map_keys(m).b from (
+ select map(named_struct('a', 1, 'b', 'n', 'c', 'x'), named_struct('a',
1, 'b', 'n', 'c', 'x')) m
+ */
+ #[tokio::test]
+ async fn test_nested_types_map_keys_by_index() -> Result<(),
DataFusionError> {
+ let session_ctx = SessionContext::new();
+
+ // generate test data in the temp folder
+ let test_data = "select map([named_struct('a', 1, 'b', 'n', 'c',
'x')], [named_struct('a', 1, 'b', 'n', 'c', 'x')]) c0";
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
