Dandandan commented on issue #16179: URL: https://github.com/apache/datafusion/issues/16179#issuecomment-2910442788
> [@Dandandan](https://github.com/Dandandan) For this, is the preferable solution to create a generic parameter, and when the hash join exec/ stream is created, based on the size of the build side we can assign the generic that value? or an enum could also possibly work? What do you think? I think we'll likely have to: * add a generic type to `JoinHashMap<T>` * make a `Box<dyn JoinHashMap>` based on the `num_rows` (num_rows <= u32::MAX => u32 else u64) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
