logan-keede commented on code in PR #16186:
URL: https://github.com/apache/datafusion/pull/16186#discussion_r2106240915
##########
datafusion/sql/src/planner.rs:
##########
@@ -235,18 +235,27 @@ impl PlannerContext {
}
// Return a reference to the outer query's schema
- pub fn outer_query_schema(&self) -> Option<&DFSchema> {
- self.outer_query_schema.as_ref().map(|s| s.as_ref())
+ pub fn outer_query_schema(&self) -> Vec<&DFSchema> {
+ self.outer_query_schema
+ .iter()
+ .map(|sc| sc.as_ref())
+ .collect()
}
/// Sets the outer query schema, returning the existing one, if
/// any
- pub fn set_outer_query_schema(
Review Comment:
same as above, but this can simply be deprecated.
##########
datafusion/sql/src/planner.rs:
##########
@@ -235,18 +235,27 @@ impl PlannerContext {
}
// Return a reference to the outer query's schema
- pub fn outer_query_schema(&self) -> Option<&DFSchema> {
Review Comment:
I think this is a breaking change. You can either make a new function or
have the PR marked. with the first option being more preferable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
