2010YOUY01 commented on PR #15700: URL: https://github.com/apache/datafusion/pull/15700#issuecomment-2906805485
> @2010YOUY01 and @ding-young I wonder if you can review this PR again to help @rluvaton get it merged? > > Specifically if it needs more tests perhaps you can help identify which are needed I have some concerns about this PR's design direction (see more in https://github.com/apache/datafusion/pull/15700#discussion_r2041372025), and I don't think it can be addressed by more extensive tests. By the way, this PR serves as an alternative to https://github.com/apache/datafusion/pull/15610. It's ready for another review, except that it needs to merge main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
