chenkovsky commented on code in PR #16167:
URL: https://github.com/apache/datafusion/pull/16167#discussion_r2105801259
##########
datafusion/functions-nested/src/length.rs:
##########
@@ -128,26 +148,20 @@ pub fn array_length_inner(args: &[ArrayRef]) ->
Result<ArrayRef> {
match &args[0].data_type() {
List(_) => general_array_length::<i32>(args),
LargeList(_) => general_array_length::<i64>(args),
+ DataType::ListView(_) => general_array_length::<i32>(args),
Review Comment:
I planed to add test, but I found it's NOT YET FULLY SUPPORTED, and there's
no slt test. maybe I should remove it first. and add it when it's fully
supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
