adriangb opened a new pull request, #16169:
URL: https://github.com/apache/datafusion/pull/16169

   I was concerned that the dance we were doing with `allowed_filters` resulted 
in the order of filters being returned to the parent differing from the order 
they were passed down in.
   
   Luckily during the design of these APIs we ended up making them agnostic to 
the ordering of filters (hence why we pass the actual `PhysicalExpr` back up) 
so there is no bug 😄 
   
   Nonetheless I decided to add tests, documentation and helpers to avoid this 
being a cause for confusion or a bug in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to