blaginin commented on code in PR #16145:
URL: https://github.com/apache/datafusion/pull/16145#discussion_r2102140935
##########
datafusion/execution/src/memory_pool/pool.rs:
##########
@@ -452,64 +453,64 @@ mod tests {
let mut r1 = MemoryConsumer::new("unspillable").register(&pool);
// Can grow beyond capacity of pool
r1.grow(2000);
- assert_eq!(pool.reserved(), 2000);
+ assert_snapshot!(pool.reserved(), @"2000");
let mut r2 = MemoryConsumer::new("r2")
.with_can_spill(true)
.register(&pool);
// Can grow beyond capacity of pool
r2.grow(2000);
- assert_eq!(pool.reserved(), 4000);
+ assert_snapshot!(pool.reserved(), @"4000");
Review Comment:
IMO this doesn’t need to be a snapshot because `4000` isn't prone to
formatting errors. For example, you snapshot errors below, which makes sense
since it allows updating messages and error structures easily. But here it’s
just a const representing test setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
