gabotechs commented on issue #15069: URL: https://github.com/apache/datafusion/issues/15069#issuecomment-2900811810
One takeaway could be to not do a roundtrip in `EXPLAIN` checks. In most cases the check will fail and it does not mean that the plan is incorrect. > so I think that'd speak for the option 2 from above One of my main motivations for - https://github.com/apache/datafusion/pull/16029 is to be able to run the different failures in isolation and report them appropriately in tickets with the respective reproducer command. What comes to mind is: 1. ship https://github.com/apache/datafusion/pull/16029 and then https://github.com/gabotechs/datafusion/pull/6 2. create a bunch of tickets with reproducer commands from the different kind of errors that we see 3. solve them until there's a fairly low amount of errors left 4. add `skipif DataFusionSubstraitRoundtrip` statements to each individual failing test 5. enforce `cargo test --test sqllogictest -- --substrait-round-trip` in the CI 6. hopefully solve all the remaining issues until there's no `skipif` statement left -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
