xudong963 commented on PR #16133: URL: https://github.com/apache/datafusion/pull/16133#issuecomment-2897577975
> says this test shouldn't pass on main, yet the CI seems to be green. Sorry for the confusion. The PR #16086 is needed You can see the comment: https://github.com/apache/datafusion/pull/16086#discussion_r2099949463, what I mean is that test in #16086 is a bit unreasonable, it's using file schema(utf8) to construct the logical filter expr. We should use table schema to construct logical filter expr. However, if using table schema to construct, the test in PR#16086 will fail because https://github.com/apache/datafusion/pull/16086/files#diff-c8eebe4fb9ee7662170c6ce507ad2be92c0229b3a91a2f4431a9bfc7185a0eb9L148 (uses file_schema to transfer logical expr to physical expr), my PR fixes there, using table schema to transfer logical expr to physical expr. https://github.com/apache/datafusion/pull/16086#pullrequestreview-2857209714 The review is saying that I used the following test to verify in different branches, the test uses table schema to build filter, to guarantee I can run the test smoothly, I need the PR's fix or it'll fail as I said above. Without #16086, the main will fail as expected, so I use ❌. ```rust let c1: ArrayRef = Arc::new(StringArray::from(vec![Some("foo"), Some("bar")])); let batch = create_batch(vec![("c1", c1.clone())]); let schema = Arc::new(Schema::new(vec![Field::new("c1", DataType::Utf8View, false)])); // Predicate should prune all row groups let filter = col("c1").eq(lit(ScalarValue::Utf8(Some("aaa".to_string())))); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
