kadai0308 commented on issue #16061:
URL: https://github.com/apache/datafusion/issues/16061#issuecomment-2887120800
After updating to Rust 1.87, I encountered several warnings such as:
```
warning: large size difference between variants
--> datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:523:1
|
523 | / enum ConstSimplifyResult {
524 | | // Expr was simplified and contains the new expression
525 | | Simplified(ScalarValue),
| | ----------------------- the second-largest variant contains at
least 64 bytes
... |
529 | | SimplifyRuntimeError(DataFusionError, Expr),
| | ------------------------------------------- the largest variant
contains at least 384 bytes
530 | | }
| |_^ the entire enum is at least 384 bytes
|
= help: for further information visit
https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
529 - SimplifyRuntimeError(DataFusionError, Expr),
529 + SimplifyRuntimeError(DataFusionError, Box<Expr>),
```
To resolve these warnings, I applied several changes involving the use of
Box for large enum variants. This required updating the types across multiple
locations in the codebase.
I'm not entirely confident that all the necessary typing changes were done
correctly, so I'd appreciate a thorough review of this PR.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
