fmonjalet commented on PR #16031: URL: https://github.com/apache/datafusion/pull/16031#issuecomment-2877308068
@jayzhan211 and @gabotechs thank you for your guidance, I updated the PR: - Expressions are not cloned anymore. - The test has been scoped to a much more unit test style, where we build a substrait `ScalarFunction` call and translate it to a DataFusion expression. I manually checked that reverting the fix made the test fail. It requires a larger argument list to trigger the issue because the expressions are simpler than in the original complex plan I submitted. Ready for a next round of feedback if any! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
