andygrove commented on code in PR #1732:
URL: https://github.com/apache/datafusion-comet/pull/1732#discussion_r2085641094
##########
spark/src/main/java/org/apache/spark/CometTaskMemoryManager.java:
##########
@@ -48,6 +48,10 @@ public CometTaskMemoryManager(long id) {
// Returns the actual amount of memory (in bytes) granted.
public long acquireMemory(long size) {
long acquired = internal.acquireExecutionMemory(size,
nativeMemoryConsumer);
+ if (acquired < size) {
+ // If memory manager is not able to acquire the requested size, log
memory usage
Review Comment:
I'd like to go ahread and merge this PR so that we can start reviewing
https://github.com/apache/datafusion-comet/pull/1730, which has many
improvements and bug fixes.
Let's keep this conversation going, though, and handle it as a follow-up PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
