iffyio commented on code in PR #1842:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1842#discussion_r2082691233
##########
src/parser/mod.rs:
##########
@@ -3471,7 +3471,7 @@ impl<'a> Parser<'a> {
right
};
- if !matches!(
+ if !dialect_of!(self is PostgreSqlDialect) && !matches!(
Review Comment:
can we use the dialect trait for this logic (dialect_of is effectively
deprecated internally)? something like `if
self.dialect.supports_arbitrary_comparison_in_subquery_operator()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
