hsiang-c commented on code in PR #1715:
URL: https://github.com/apache/datafusion-comet/pull/1715#discussion_r2078058620
##########
dev/diffs/iceberg/1.8.1.diff:
##########
@@ -0,0 +1,179 @@
+diff --git a/spark/v3.4/build.gradle b/spark/v3.4/build.gradle
+index 6eb26e8..90d848d 100644
+--- a/spark/v3.4/build.gradle
++++ b/spark/v3.4/build.gradle
+@@ -75,7 +75,7 @@
project(":iceberg-spark:iceberg-spark-${sparkMajorVersion}_${scalaVersion}") {
+ exclude group: 'org.roaringbitmap'
+ }
+
+- compileOnly
"org.apache.datafusion:comet-spark-spark${sparkMajorVersion}_${scalaVersion}:0.5.0"
++ compileOnly
"org.apache.datafusion:comet-spark-spark${sparkMajorVersion}_${scalaVersion}:0.9.0-SNAPSHOT"
+
+ implementation libs.parquet.column
+ implementation libs.parquet.hadoop
+@@ -185,7 +185,7 @@
project(":iceberg-spark:iceberg-spark-extensions-${sparkMajorVersion}_${scalaVer
+ testImplementation libs.avro.avro
+ testImplementation libs.parquet.hadoop
+ testImplementation libs.junit.vintage.engine
+- testImplementation
"org.apache.datafusion:comet-spark-spark${sparkMajorVersion}_${scalaVersion}:0.5.0"
++ testImplementation
"org.apache.datafusion:comet-spark-spark${sparkMajorVersion}_${scalaVersion}:0.9.0-SNAPSHOT"
+
+ // Required because we remove antlr plugin dependencies from the compile
configuration, see note above
+ runtimeOnly libs.antlr.runtime
+@@ -260,6 +260,7 @@
project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio
+ integrationImplementation project(path: ':iceberg-hive-metastore',
configuration: 'testArtifacts')
+ integrationImplementation project(path:
":iceberg-spark:iceberg-spark-${sparkMajorVersion}_${scalaVersion}",
configuration: 'testArtifacts')
+ integrationImplementation project(path:
":iceberg-spark:iceberg-spark-extensions-${sparkMajorVersion}_${scalaVersion}",
configuration: 'testArtifacts')
++ integrationImplementation
"org.apache.datafusion:comet-spark-spark${sparkMajorVersion}_${scalaVersion}:0.9.0-SNAPSHOT"
+
+ // runtime dependencies for running Hive Catalog based integration test
+ integrationRuntimeOnly project(':iceberg-hive-metastore')
+@@ -297,8 +298,8 @@
project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio
+ relocate 'org.apache.avro', 'org.apache.iceberg.shaded.org.apache.avro'
+ relocate 'avro.shaded', 'org.apache.iceberg.shaded.org.apache.avro.shaded'
+ relocate 'com.thoughtworks.paranamer',
'org.apache.iceberg.shaded.com.thoughtworks.paranamer'
+- relocate 'org.apache.parquet',
'org.apache.iceberg.shaded.org.apache.parquet'
+- relocate 'shaded.parquet',
'org.apache.iceberg.shaded.org.apache.parquet.shaded'
++// relocate 'org.apache.parquet',
'org.apache.iceberg.shaded.org.apache.parquet'
++// relocate 'shaded.parquet',
'org.apache.iceberg.shaded.org.apache.parquet.shaded'
Review Comment:
@kazuyukitanimura Yes, according to the
[doc](https://github.com/apache/datafusion-comet/blob/main/docs/source/user-guide/iceberg.md#build-iceberg)
and https://github.com/apache/datafusion-comet/pull/1683, we need to stop
shading parquet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
