andygrove commented on code in PR #1706:
URL: https://github.com/apache/datafusion-comet/pull/1706#discussion_r2076103044
##########
native/core/src/execution/jni_api.rs:
##########
@@ -767,3 +750,20 @@ pub unsafe extern "system" fn
Java_org_apache_comet_Native_traceEnd(
) {
// no implementation
}
+
+struct TraceGuard<'a> {
Review Comment:
I ran into some issues around lifetimes for captured variables with this
approach, so perhaps it is simpler to stick with the TraceGuard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
