shehabgamin commented on issue #15916: URL: https://github.com/apache/datafusion/issues/15916#issuecomment-2852130041
> [@shehabgamin](https://github.com/shehabgamin) and [@andygrove](https://github.com/andygrove) -- here is a ticket for another spark function. I am hoping we can do one or two of these functions to set a pattern, and then we will be able to basically copy the pattern for the rest of the library > > Questions for you: > > 1. Is there any other function(s) that you would recommend as one of the first to try and consolidate? > > 2. Are you willing to try and make a PR to add this function? 1. `Ceil` and `Floor` are essentially the same function (in terms of code). Sail already has both these functions implemented, see here: https://github.com/lakehq/sail/blob/main/crates/sail-plan/src/extension/function/math/spark_ceil_floor.rs 2. Not sure when I would have time, if someone else is eager to take it on that would be great! Otherwise, I can add it to my list. Should be an easy copy paste from the Sail code base hopefully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
