robtandy commented on code in PR #1107:
URL:
https://github.com/apache/datafusion-python/pull/1107#discussion_r2056227303
##########
src/functions.rs:
##########
@@ -698,8 +677,22 @@ pub fn approx_percentile_cont_with_weight(
add_builder_fns_to_aggregate(agg_fn, None, filter, None, None)
}
-aggregate_function_vec_args!(last_value);
+// We handle first_value explicitly because the signature expects an order_by
Review Comment:
Should this comment address first and last value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
