geoffreyclaude commented on code in PR #15315:
URL: https://github.com/apache/datafusion/pull/15315#discussion_r2049224450
##########
.github/actions/setup-rust-runtime/action.yaml:
##########
@@ -16,23 +16,22 @@
# under the License.
name: Setup Rust Runtime
-description: 'Setup Rust Runtime Environment'
+description: "Setup Rust Runtime Environment"
runs:
using: "composite"
steps:
- name: Run sccache-cache
- uses: mozilla-actions/sccache-action@v0.0.4
+ uses:
mozilla-actions/sccache-action@2e7f9ec7921547d4b46598398ca573513895d0bd
- name: Configure runtime env
shell: bash
# do not produce debug symbols to keep memory usage down
# hardcoding other profile params to avoid profile override values
# More on Cargo profiles
https://doc.rust-lang.org/cargo/reference/profiles.html?profile-settings#profile-settings
- #
+ #
# Set debuginfo=line-tables-only as debuginfo=0 causes immensely slow
build
# See for more details: https://github.com/rust-lang/rust/issues/119560
run: |
echo "RUSTC_WRAPPER=sccache" >> $GITHUB_ENV
echo "SCCACHE_GHA_ENABLED=true" >> $GITHUB_ENV
echo "RUST_BACKTRACE=1" >> $GITHUB_ENV
echo "RUSTFLAGS=-C debuginfo=line-tables-only -C incremental=false" >>
$GITHUB_ENV
Review Comment:
The `-C incremental=false` was introduced in
https://github.com/apache/datafusion/pull/8730, but I'm pretty sure it should
actually be disabled with an env variable instead:
```bash
echo "CARGO_INCREMENTAL=0" >> $GITHUB_ENV
```
The `RUSTCFLAGS`
[`incremental`](https://doc.rust-lang.org/rustc/codegen-options/index.html#incremental)
only specifies the "path to a directory where incremental files will be
stored" — so in this case it is requesting to store incremental files in the
folder named "false".
Since sccache does not cache incremental files, using the env var instead of
the flag should have some good improvements on the sccache hit rate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
