andygrove commented on code in PR #1619:
URL: https://github.com/apache/datafusion-comet/pull/1619#discussion_r2039766214
##########
native/core/src/parquet/parquet_exec.rs:
##########
@@ -61,7 +61,12 @@ pub(crate) fn init_datasource_exec(
data_filters: Option<Vec<Arc<dyn PhysicalExpr>>>,
session_timezone: &str,
) -> Result<Arc<DataSourceExec>, ExecutionError> {
- let (table_parquet_options, spark_parquet_options) =
get_options(session_timezone);
+ let has_data_filters = match &data_filters {
+ Some(filters) => !filters.is_empty(),
+ None => false,
+ };
Review Comment:
This may be redundant .. if there are no filters then we probably don't need
to change the DataFusion pushdown options
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
