UBarney commented on issue #15676: URL: https://github.com/apache/datafusion/issues/15676#issuecomment-2795784149
> > I implemented it according to the behavior defined in this document > > > Returns the last element in an aggregation group according to the requested ordering. **If no ordering is given, returns an arbitrary** element from the group. > > > > > > https://datafusion.apache.org/user-guide/sql/aggregate_functions.html#last-value > > The doc isn't correct, we should return the last value in the group As an aside, I'm not sure if the return value of `last_value` (as implemented previously) is stable if no ordering is specified, even if the input is in order. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org