Dandandan commented on code in PR #15643:
URL: https://github.com/apache/datafusion/pull/15643#discussion_r2033973152
##########
datafusion/physical-plan/src/aggregates/group_values/single_group_by/primitive.rs:
##########
@@ -156,23 +183,33 @@ where
}
fn len(&self) -> usize {
- self.values.len()
+ self.values.len().saturating_sub(1) * BLOCK_SIZE
+ + self.values.last().map_or(0, |v| v.len())
}
fn emit(&mut self, emit_to: EmitTo) -> Result<Vec<ArrayRef>> {
Review Comment:
Emit could be changed to support returning multiple arrays
(`Result<Vec<Vec<ArrayRef>>>`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
